fix: Correct K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION env var#2202
Open
fatmcgav wants to merge 1 commit intografana:mainfrom
Open
fix: Correct K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION env var#2202fatmcgav wants to merge 1 commit intografana:mainfrom
K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION env var#2202fatmcgav wants to merge 1 commit intografana:mainfrom
Conversation
…heus remote write docs The env var implemented in grafana/k6#5537 is `K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION`, whereas the docs suggest `K6_PROMETHEUS_RW_TLS_MIN_VERSION`. Updating docs to reflect implmeneted env var.
|
|
Collaborator
|
@fatmcgav thanks for opening the PR! You're right, it looks the variable name is wrong. Would you mind updating the file in the two previous versions as well? If not, that's ok, I can just merge your PR and open a separate one to do that. 😇 |
Author
|
@heitortsergent Yeh, should be able to later today or tomorrow 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The env var implemented in grafana/k6#5537 is
K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION, whereas the docs suggestK6_PROMETHEUS_RW_TLS_MIN_VERSION.Updating docs to reflect implmeneted env var.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.docs/sources/k6/v{most_recent_release}folder of the documentation.docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)
grafana/k6#5537