Skip to content

fix: Correct K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION env var#2202

Open
fatmcgav wants to merge 1 commit intografana:mainfrom
fatmcgav:docs-fix-prometheus-min-tls-version-env
Open

fix: Correct K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION env var#2202
fatmcgav wants to merge 1 commit intografana:mainfrom
fatmcgav:docs-fix-prometheus-min-tls-version-env

Conversation

@fatmcgav
Copy link

@fatmcgav fatmcgav commented Mar 4, 2026

What?

The env var implemented in grafana/k6#5537 is K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION, whereas the docs suggest K6_PROMETHEUS_RW_TLS_MIN_VERSION.

Updating docs to reflect implmeneted env var.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

grafana/k6#5537

…heus remote write docs

The env var implemented in grafana/k6#5537 is `K6_PROMETHEUS_RW_TLS_MINIMUM_VERSION`, whereas the docs suggest `K6_PROMETHEUS_RW_TLS_MIN_VERSION`.

Updating docs to reflect implmeneted env var.
@fatmcgav fatmcgav requested review from a team and heitortsergent as code owners March 4, 2026 12:28
@fatmcgav fatmcgav requested review from ankur22 and joanlopez and removed request for a team March 4, 2026 12:28
@cla-assistant
Copy link

cla-assistant bot commented Mar 4, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Mar 4, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@heitortsergent
Copy link
Collaborator

@fatmcgav thanks for opening the PR! You're right, it looks the variable name is wrong.

Would you mind updating the file in the two previous versions as well? If not, that's ok, I can just merge your PR and open a separate one to do that. 😇

@heitortsergent heitortsergent self-assigned this Mar 5, 2026
@heitortsergent heitortsergent added the Area: OSS Content Improvements or additions to community/oss documentation label Mar 5, 2026
@fatmcgav
Copy link
Author

fatmcgav commented Mar 5, 2026

@heitortsergent Yeh, should be able to later today or tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: OSS Content Improvements or additions to community/oss documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants