Skip to content

Retry on HTTP 500 Internal Server Error#285

Merged
inancgumus merged 1 commit intomainfrom
add-500-retry
Mar 12, 2026
Merged

Retry on HTTP 500 Internal Server Error#285
inancgumus merged 1 commit intomainfrom
add-500-retry

Conversation

@inancgumus
Copy link
Contributor

@inancgumus inancgumus commented Mar 11, 2026

What

  • Adds http.StatusInternalServerError to shouldRetry() so the build client retries on transient 500s

Why

  • Handling of 500 avoids transient failures in k6-cloud-testcoordinator.

Related

  • grafana/k6-cloud#4279

The build service client retried on 502/503/504 but not on 500.
Transient 500s from the build service were not retried, causing
unnecessary failures in downstream consumers.
@inancgumus inancgumus self-assigned this Mar 11, 2026
@inancgumus inancgumus requested review from Lantero and szkiba March 11, 2026 17:33
Copy link
Contributor

@szkiba szkiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit 3f97a69 into main Mar 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants