chore: update daemonset to use resource processor #46
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -61,8 +61,9 @@ kwok: generate | |||||
|
|
||||||
| .PHONY: kwok-down | ||||||
| kwok-down: | ||||||
| @docker rm -f kwok-otel-collector kwok-otel-gateway kwok-stats-proxy kwok-beyla lgtm 2>/dev/null || true | ||||||
| @for c in $$(docker ps -a -q --filter "name=kwok-hostmetrics" 2>/dev/null); do docker rm -f $$c 2>/dev/null || true; done | ||||||
|
There was a problem hiding this comment. The filter pattern has been changed from "name=kwok-hostmetrics-replicator" to "name=kwok-hostmetrics". This is a broader filter that will match any container name starting with "kwok-hostmetrics", including "kwok-hostmetrics-replicator" and potentially other containers. Ensure this is intentional and that you want to clean up all containers matching this pattern, not just the replicator containers.
Suggested change
|
||||||
| @for c in $$(docker network inspect kwok-$(CLUSTER_NAME) --format '{{range .Containers}}{{.Name}} {{end}}' 2>/dev/null); do docker rm -f $$c 2>/dev/null || true; done | ||||||
| @kwokctl delete cluster --name $(CLUSTER_NAME) 2>/dev/null || true | ||||||
| @echo "KWOK environment torn down" | ||||||
|
|
||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| FROM golang:1.26-alpine AS builder | ||||||
|
There was a problem hiding this comment. The SHA256 digest pin has been removed from the FROM instruction. This makes the build less reproducible and could introduce supply chain security risks, as the image tag could potentially point to different content over time. Consider keeping the digest pin for better security and reproducibility, especially for production builds.
Suggested change
|
||||||
|
|
||||||
| WORKDIR /app | ||||||
| COPY go.mod go.sum* ./ | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,8 +49,8 @@ config: | |
| extract: | ||
| otel_annotations: true | ||
|
|
||
| resource/k8sclustername: | ||
| attributes: | ||
| - key: k8s.cluster.name | ||
| action: upsert | ||
| value: kubernetes-mixin-otel | ||
|
Comment on lines
+52
to
56
There was a problem hiding this comment. The processor name has been updated from |
||
|
|
@@ -91,7 +91,7 @@ config: | |
| processors: [ | ||
| resourcedetection, | ||
| k8sattributes, | ||
| resource/k8sclustername, | ||
| resource/hostname, | ||
| transform/copy_node_name, | ||
| batch, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cleanup now includes removal of a 'kwok-otel-gateway' container, but there are no references to this container being created in any of the scripts in the repository. If this container is created elsewhere or is planned for future use, this is fine. Otherwise, this cleanup step may be unnecessary.