Skip to content

Conversation

@jotak
Copy link
Contributor

@jotak jotak commented May 21, 2024

Related: observatorium/opa-openshift#24 - this has to be merged first / I'll keep this PR as draft in the meantime.

What this PR does / why we need it:

In Loki operator, when set up with openshift for network logs, pass the --opa.skip-namespace-inference flag set to true to allow fine-grained RBAC

Which issue(s) this PR fixes:
Fixes a downstream bug related to the use of the Loki operator by NetObserv, and Loki returning an error about "input size too long". Downstream issue: https://issues.redhat.com/browse/NETOBSERV-1324

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

In Loki operator, when set up with openshift for network logs, pass the
--opa.skip-namespace-inference flag set to true to allow fine-grained
RBAC

Related: observatorium/opa-openshift#24

Signed-off-by: Joel Takvorian <[email protected]>
@jotak jotak changed the title Pass --opa.skip-namespace-inference flag to OPA openshift fix: Pass --opa.skip-namespace-inference flag to OPA openshift May 30, 2024
@periklis periklis closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants