-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: openshift mode to allow both logging and network #19249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
55a3176 to
ef69466
Compare
7bb7e00 to
c0d726d
Compare
c0d726d to
e789463
Compare
e789463 to
6ab8f6c
Compare
|
@jpinsonneau - I did a performance test on this and loki is able ingest both logging and network logs well, I am not seeing prominent log loss or any errors for loki. I set up 5 worker nodes and for logging had 8 pods within each NS generating 90,000 lines of logs lines every 30 mins. I had 5 such namespaces, bringing total of 40 pods. I also added netobserv workload on top of it. You can see below data for one of such ns which was generating logs at above mentioned rate, for most part if collected 720000 log lines (90,000 * 8 (number of pod replicas) starting at 30 mins mark. There was some loss in the trailing data but unsure if it was something that collector dropped or loki. I did not see Loki errors during the test. |
Awesome, thanks for testing this @memodi ! |
002ee46 to
53a0a79
Compare
What this PR does / why we need it:
This PR implements a new
Openshiftmode supporting both logging and network logs at same time. This is a trivial change despite the PR is quite large.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
You will need observatorium/opa-openshift#37 to test this PR.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR