Skip to content

fix(compactor): fix fd leak after failed index load #19408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(compactor): fix fd leak after failed index load #19408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions pkg/storage/stores/shipper/indexshipper/tsdb/compactor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,22 +115,27 @@ func (t *tableCompactor) CompactTable() error {

return nil
})
if err != nil {
return err
}

defer func() {
for i, idx := range multiTenantIndices {
if err := idx.Close(); err != nil {
level.Error(t.commonIndexSet.GetLogger()).Log("msg", "failed to close multi-tenant source index file", "path", downloadPaths[i], "err", err)
// indices or paths may not be set in case of partially failed download and open
if idx != nil {
if err := idx.Close(); err != nil {
level.Error(t.commonIndexSet.GetLogger()).Log("msg", "failed to close multi-tenant source index file", "path", downloadPaths[i], "err", err)
}
}

if err := os.Remove(downloadPaths[i]); err != nil {
level.Error(t.commonIndexSet.GetLogger()).Log("msg", "failed to remove downloaded index file", "path", downloadPaths[i], "err", err)
if downloadPaths[i] != "" {
if err := os.Remove(downloadPaths[i]); err != nil {
level.Error(t.commonIndexSet.GetLogger()).Log("msg", "failed to remove downloaded index file", "path", downloadPaths[i], "err", err)
}
}
}
}()

if err != nil {
return err
}

var multiTenantIndex Index = NoopIndex{}
if len(multiTenantIndices) > 0 {
multiTenantIndex = NewMultiIndex(IndexSlice(multiTenantIndices))
Expand Down