Skip to content

feat(helm): Add startupProbe to compactor #20072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −0
Open

feat(helm): Add startupProbe to compactor #20072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa0ecd6
feat(helm): Add startupProbe to compactor
lindhe Dec 12, 2024
7944d3b
chore(helm): Update reference.md
lindhe Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/sources/setup/install/helm/reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3117,6 +3117,7 @@ null
"serviceAnnotations": {},
"serviceLabels": {},
"serviceType": "ClusterIP",
"startupProbe": {},
"terminationGracePeriodSeconds": 30,
"tolerations": []
}
Expand Down Expand Up @@ -3467,6 +3468,15 @@ null
<td><pre lang="json">
"ClusterIP"
</pre>
</td>
</tr>
<tr>
<td>compactor.startupProbe</td>
<td>object</td>
<td>liveness probe settings for ingester pods. If empty use `loki.livenessProbe`</td>
<td><pre lang="json">
{}
</pre>
</td>
</tr>
<tr>
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Entries should include a reference to the pull request that introduced the chang
- [ENHANCEMENT] Add support for configuring `volumeAttributesClassName` for `volumeClaimTemplates`. [#19719](https://github.com/grafana/loki/pull/19719)
- [BUGFIX] Don't fail for missing bucket name, if minio is enabled. [#19745](https://github.com/grafana/loki/pull/19745)
- [BUGFIX] Add startupProbe to read pod [#19708](https://github.com/grafana/loki/pull/19708)
- [ENHANCEMENT] Add configurable `startupProbe` to compactor [#20072](https://github.com/grafana/loki/pull/20072).

## 6.46.0

Expand Down
10 changes: 10 additions & 0 deletions production/helm/loki/templates/compactor/_helpers-compactor.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ livenessProbe:
{{- end }}
{{- end }}

{{/*
compactor startup probe
*/}}
{{- define "loki.compactor.startupProbe" }}
{{- with .Values.compactor.startupProbe | default .Values.loki.startupProbe }}
startupProbe:
{{- toYaml . | nindent 2 }}
{{- end }}
{{- end }}

{{/*
compactor priority class name
*/}}
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/compactor/statefulset-compactor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ spec:
{{- toYaml .Values.loki.containerSecurityContext | nindent 12 }}
{{- include "loki.compactor.readinessProbe" . | nindent 10 }}
{{- include "loki.compactor.livenessProbe" . | nindent 10 }}
{{- include "loki.compactor.startupProbe" . | nindent 10 }}
volumeMounts:
- name: temp
mountPath: /tmp
Expand Down
2 changes: 2 additions & 0 deletions production/helm/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2775,6 +2775,8 @@ compactor:
readinessProbe: {}
# -- liveness probe settings for ingester pods. If empty use `loki.livenessProbe`
livenessProbe: {}
# -- liveness probe settings for ingester pods. If empty use `loki.livenessProbe`
startupProbe: {}
# -- Resource requests and limits for the compactor
resources: {}
# -- Containers to add to the compactor pods
Expand Down
Loading