Skip to content

feat(helm): Add startupProbe to ingester #20076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −0
Open

feat(helm): Add startupProbe to ingester #20076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/sources/setup/install/helm/reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6045,6 +6045,7 @@ null
"serviceAnnotations": {},
"serviceLabels": {},
"serviceType": "ClusterIP",
"startupProbe": {},
"terminationGracePeriodSeconds": 300,
"tolerations": [],
"topologySpreadConstraints": [
Expand Down Expand Up @@ -6495,6 +6496,15 @@ false
<td><pre lang="json">
"ClusterIP"
</pre>
</td>
</tr>
<tr>
<td>ingester.startupProbe</td>
<td>object</td>
<td>startup probe settings for ingester pods. If empty use `loki.startupProbe`</td>
<td><pre lang="json">
{}
</pre>
</td>
</tr>
<tr>
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Entries should include a reference to the pull request that introduced the chang
- [ENHANCEMENT] Add support for configuring `volumeAttributesClassName` for `volumeClaimTemplates`. [#19719](https://github.com/grafana/loki/pull/19719)
- [BUGFIX] Don't fail for missing bucket name, if minio is enabled. [#19745](https://github.com/grafana/loki/pull/19745)
- [BUGFIX] Add startupProbe to read pod [#19708](https://github.com/grafana/loki/pull/19708)
- [ENHANCEMENT] Add configurable `startupProbe` to ingester [#20076](https://github.com/grafana/loki/pull/20076)

## 6.46.0

Expand Down
10 changes: 10 additions & 0 deletions production/helm/loki/templates/ingester/_helpers-ingester.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,16 @@ livenessProbe:
{{- end }}
{{- end }}

{{/*
ingester startup probe
*/}}
{{- define "loki.ingester.startupProbe" }}
{{- with .Values.ingester.startupProbe | default .Values.loki.startupProbe }}
startupProbe:
{{- toYaml . | nindent 2 }}
{{- end }}
{{- end }}

{{/*
expects global context
*/}}
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/ingester/statefulset-ingester-zone-a.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ spec:
{{- toYaml .Values.loki.containerSecurityContext | nindent 12 }}
{{- include "loki.ingester.readinessProbe" . | nindent 10 }}
{{- include "loki.ingester.livenessProbe" . | nindent 10 }}
{{- include "loki.ingester.startupProbe" . | nindent 10 }}
volumeMounts:
- name: config
mountPath: /etc/loki/config
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/ingester/statefulset-ingester-zone-b.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ spec:
{{- toYaml .Values.loki.containerSecurityContext | nindent 12 }}
{{- include "loki.ingester.readinessProbe" . | nindent 10 }}
{{- include "loki.ingester.livenessProbe" . | nindent 10 }}
{{- include "loki.ingester.startupProbe" . | nindent 10 }}
volumeMounts:
- name: config
mountPath: /etc/loki/config
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/ingester/statefulset-ingester-zone-c.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ spec:
{{- toYaml .Values.loki.containerSecurityContext | nindent 12 }}
{{- include "loki.ingester.readinessProbe" . | nindent 10 }}
{{- include "loki.ingester.livenessProbe" . | nindent 10 }}
{{- include "loki.ingester.startupProbe" . | nindent 10 }}
volumeMounts:
- name: config
mountPath: /etc/loki/config
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/ingester/statefulset-ingester.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ spec:
{{- toYaml .Values.loki.containerSecurityContext | nindent 12 }}
{{- include "loki.ingester.readinessProbe" . | nindent 10 }}
{{- include "loki.ingester.livenessProbe" . | nindent 10 }}
{{- include "loki.ingester.startupProbe" . | nindent 10 }}
volumeMounts:
- name: config
mountPath: /etc/loki/config
Expand Down
2 changes: 2 additions & 0 deletions production/helm/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,6 +2095,8 @@ ingester:
readinessProbe: {}
# -- liveness probe settings for ingester pods. If empty use `loki.livenessProbe`
livenessProbe: {}
# -- startup probe settings for ingester pods. If empty use `loki.startupProbe`
startupProbe: {}
# -- UpdateStrategy for the ingester StatefulSets.
updateStrategy:
# -- One of 'OnDelete' or 'RollingUpdate'
Expand Down
Loading