Skip to content

feat: add gauge to track in-flight bytes #20091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

feat: add gauge to track in-flight bytes #20091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pkg/distributor/distributor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,11 @@ type Distributor struct {
// are consumed.
numMetadataPartitions int

// inflightBytes keeps track of the total number of bytes for all in-flight
// push requests.
inflightBytes atomic.Uint64
inflightBytesGauge prometheus.Gauge

// kafka metrics
kafkaAppends *prometheus.CounterVec
kafkaWriteBytesTotal prometheus.Counter
Expand Down Expand Up @@ -391,6 +396,12 @@ func New(
partitionRing: partitionRing,
ingestLimits: ingestLimits,
numMetadataPartitions: numMetadataPartitions,
inflightBytes: *atomic.NewUint64(0),
inflightBytesGauge: promauto.With(registerer).NewGauge(prometheus.GaugeOpts{
Namespace: constants.Loki,
Name: "distributor_inflight_bytes",
Help: "The number of bytes currently inflight.",
}),
}

if overrides.IngestionRateStrategy() == validation.GlobalIngestionRateStrategy {
Expand Down Expand Up @@ -539,6 +550,14 @@ func (d *Distributor) Push(ctx context.Context, req *logproto.PushRequest) (*log
// Push a set of streams.
// The returned error is the last one seen.
func (d *Distributor) PushWithResolver(ctx context.Context, req *logproto.PushRequest, streamResolver *requestScopedStreamResolver, format string) (*logproto.PushResponse, error) {
requestSizeBytes := uint64(req.Size())
d.inflightBytes.Add(requestSizeBytes)
d.inflightBytesGauge.Add(float64(requestSizeBytes))
defer func() {
d.inflightBytes.Sub(requestSizeBytes)
d.inflightBytesGauge.Sub(float64(requestSizeBytes))
}()

tenantID, err := tenant.TenantID(ctx)
if err != nil {
return nil, err
Expand Down
Loading