Skip to content

chore(engine): more descriptive span names in thread.runJob #20960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bboreham wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Draft

chore(engine): more descriptive span names in thread.runJob #20960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/engine/internal/worker/thread.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (t *thread) runJob(ctx context.Context, job *threadJob) {
ctx, capture := xcap.NewCapture(ctx, nil)
defer capture.End()

ctx, span := xcap.StartSpan(ctx, tracer, "thread.runJob",
ctx, span := xcap.StartSpan(ctx, tracer, runJobSpanName(job.Task.Fragment),
trace.WithAttributes(attribute.Stringer("task_id", job.Task.ULID)),
)
defer span.End()
Expand Down Expand Up @@ -305,6 +305,14 @@ func (t *thread) runJob(ctx context.Context, job *threadJob) {
}
}

func runJobSpanName(plan *physical.Plan) string {
root, err := plan.Root()
if err != nil { // No root or multiple roots.
return "thread.runJob"
}
return "thread.runJob " + root.Type().String()
}

func (t *thread) drainPipeline(ctx context.Context, pipeline executor.Pipeline, sinks []recordSink, batchSizeRecords int64, logger log.Logger) (int, error) {
region := xcap.RegionFromContext(ctx)

Expand Down
Loading