Skip to content

ci: expose suite option, use exhaustive for cron#20972

Open
trevorwhitney wants to merge 1 commit intomainfrom
twhitney/dispatch-logql-benchmarks
Open

ci: expose suite option, use exhaustive for cron#20972
trevorwhitney wants to merge 1 commit intomainfrom
twhitney/dispatch-logql-benchmarks

Conversation

@trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

  • Exposes a suite option to manual dispatches of the LogQL Correctness job
  • Makes the cron job use the exhaustive suite

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Copilot AI review requested due to automatic review settings February 26, 2026 04:12
@trevorwhitney trevorwhitney requested a review from a team as a code owner February 26, 2026 04:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the LogQL correctness GitHub Actions workflow to let manually-triggered runs select a test suite, and ensures scheduled (cron) runs execute the most comprehensive suite.

Changes:

  • Adds a suite choice input to workflow_dispatch with fast, regression, and exhaustive options.
  • Updates the test runner step to compute a SUITE regex based on the selected suite.
  • Makes scheduled runs default to the exhaustive suite while keeping other triggers defaulting to regression.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants