Skip to content

Conversation

sd2k
Copy link
Collaborator

@sd2k sd2k commented Sep 18, 2025

Addresses #290.

@sd2k sd2k marked this pull request as ready for review September 19, 2025 09:16
@sd2k sd2k requested a review from a team as a code owner September 19, 2025 09:16
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions

This comment has been minimized.

@okianus
Copy link

okianus commented Oct 3, 2025

Some notes from a conversation with @sd2k:

Two separate requirements:

  1. the MCPB manifest, which defines how the server should be packaged up for installation and consumption (independent of Docker)
  2. the server.json manifest, which is required for adding it to the registry (could either add our server as a Docker image or an MCPB package)

If we want to add it as a Docker image we need to build and tag our image, but the problem is that our Docker image isn't built by our repo but by Docker's mcp-registry repo.

We can update our Dockerfile to include the required label (LABEL io.modelcontextprotocol.server.name="io.github.username/server-name") but the issue is that those Docker builds controlled by Docker's mcp-registry repo don't include versioned tags. A better approach is to do the MCPB manifest, then use that manifest in our server.json rather than using a Docker image, so the steps would be:

  1. remove server.json and the docker build GitHub Actions workflow from that PR (for now)
  2. add a separate GitHub action to build the MCPB and add it to the GitHub releases on each tag
  3. make sure we can build the MCPB (and hopefully validate it)

Once that is done & merged, we can add a server.json which uses the MCPB as mentioned in these requirements.

But this approach has an issue that our server is a Go binary so needs the platform specified but that isn't supported by MCPB yet (see this and this). Using Node.js approach sounds like a bad idea, the alternative is to wait for MCPB to support platform-specific builds. Using our own Docker image published to the Docker hub is another option.

@ioanarm ioanarm force-pushed the add-mcpb-manifest.json branch from 97ad92e to ce7a739 Compare October 10, 2025 14:26
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@ioanarm
Copy link
Contributor

ioanarm commented Oct 10, 2025

@sd2k and @okianus we now have our own docker image with the label required to publish to the mcp registry.
https://hub.docker.com/repository/docker/grafana/mcp-grafana

This should be good to go! Have a look and let me know!

@sd2k
Copy link
Collaborator Author

sd2k commented Oct 10, 2025

Hm I think we can use the custom Docker image for the server.json but not for the MCPB manifest? Let's chat on Monday

sd2k added a commit that referenced this pull request Oct 14, 2025
Also update the 'docker' CI workflow to publish to the registry after
building and pushing the image.

This is split out of #291 since it's actually a different thing; this PR
adds our MCP server to the registry, using the Docker image. The other
will add an MCPB manifest which we _could_ use for the registry instead,
and which can be used for Claude Desktop.
sd2k added a commit that referenced this pull request Oct 14, 2025
Also update the 'docker' CI workflow to publish to the registry after
building and pushing the image.

This is split out of #291 since it's actually a different thing; this PR
adds our MCP server to the registry, using the Docker image. The other
will add an MCPB manifest which we _could_ use for the registry instead,
and which can be used for Claude Desktop.
sd2k added a commit that referenced this pull request Oct 14, 2025
* chore: add server.json for MCP registry

Also update the 'docker' CI workflow to publish to the registry after
building and pushing the image.

This is split out of #291 since it's actually a different thing; this PR
adds our MCP server to the registry, using the Docker image. The other
will add an MCPB manifest which we _could_ use for the registry instead,
and which can be used for Claude Desktop.

* Use $VERSION in server.json so it's obvious it's overwritten
Addresses #290.

Co-authored-by: okianus <[email protected]>
Co-authored-by: Ioanna Armouti <[email protected]>
@sd2k sd2k force-pushed the add-mcpb-manifest.json branch from d2ac0a9 to 5c507b5 Compare October 17, 2025 09:02
@sd2k sd2k marked this pull request as draft October 17, 2025 09:02
@sd2k
Copy link
Collaborator Author

sd2k commented Oct 17, 2025

I've removed the server.json and Docker changes from this PR since those were done in #323; this now just contains the manifest.json. Unfortunately it's still not workable due to anthropics/mcpb#10 and anthropics/mcpb#63, so I'll mark as draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants