WIP: Add /api/v1/info_labels endpoint for PromQL info() autocomplete#14168
Draft
WIP: Add /api/v1/info_labels endpoint for PromQL info() autocomplete#14168
Conversation
Port the /api/v1/info_labels endpoint from mimir-prometheus to enable autocomplete suggestions for the PromQL info() function. This endpoint returns data labels from info metrics (like target_info). The endpoint is routed through the labels middleware for caching, validation, and retry behavior consistent with other label queries. Changes: - Update mimir-prometheus dependency to arve/info-autocomplete branch - Register /api/v1/info_labels route in API and handlers - Add IsInfoLabelsQuery() detection in query frontend middleware - Handle info_labels in codec's DecodeLabelsSeriesQueryRequest - Add comprehensive test coverage Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/info-autocomplete
branch
from
b3eb28f to
06b0c53
Compare
aknuds1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a new
/api/v1/info_labelsAPI endpoint that returns data labels from info metrics (liketarget_info) for use in autocomplete suggestions for the PromQLinfo()function. Mimir port of prometheus/prometheus#17930, which is also work in progress.Key changes:
/api/v1/info_labelsendpoint in the querier that queries store-gateways and ingestersil:)Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.