Use limiter.NewUnlimitedMemoryConsumptionTracker where possible#14508
Merged
charleskorn merged 1 commit intomainfrom Feb 27, 2026
Merged
Use limiter.NewUnlimitedMemoryConsumptionTracker where possible#14508charleskorn merged 1 commit intomainfrom
limiter.NewUnlimitedMemoryConsumptionTracker where possible#14508charleskorn merged 1 commit intomainfrom
Conversation
charleskorn
added
the
changelog-not-needed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR addresses #14377 (comment), simplifying code in tests.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Low Risk
Test-only refactor that swaps tracker construction helpers without changing production logic; low risk aside from potential test behavior differences if the unlimited helper is misused.
Overview
Updates a broad set of query/streaming PromQL and streaming-reader tests to construct memory trackers via
limiter.NewUnlimitedMemoryConsumptionTracker(...)instead ofNewMemoryConsumptionTracker(..., 0, nil, ""), making the no-limit but still tracked intent explicit.Also adjusts limiter tracker context/benchmark tests to use the new helper where appropriate, keeping the remaining limited-memory tests on the explicit constructor.
Written by Cursor Bugbot for commit b3c3663. This will update automatically on new commits. Configure here.