Handle split nodes as regular nodes if range vector splitting is disabled on queriers#14517
Open
Handle split nodes as regular nodes if range vector splitting is disabled on queriers#14517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
For range vector splitting to work, it has to be enabled both on the query-frontend (for planning) and the queriers (for the actual execution of the splitting). Currently, if it is enabled on the query-frontend but disabled on the queriers, an error will be returned. To avoid errors, you'd have to enable on the queriers first and then on the query-frontend.
To make enabling query splitting less manual without errors one rollout, this PR changes the split node materializer logic to just materialize the original node if splitting is disabled.
Which issue(s) this PR fixes or relates to
Follow up to #13472
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Low Risk
Changes split range-vector execution to degrade gracefully (with a warning) instead of failing when queriers have splitting disabled, reducing rollout risk but slightly altering behavior in a misconfigured setup.
Overview
Prevents query failures when a
SplitFunctionCallnode arrives at a querier withRangeVectorSplittingdisabled by materializing and executing the wrappedFunctionCallnormally (and logging a warning) instead of returning an error.Refactors the split materializer registration to always use
rangevectorsplitting.NewMaterializer(enabled, cache, logger), removes the genericDisabledMaterializer, and updates/extends tests to cover the query-frontend-enabled/querier-disabled fallback case.Written by Cursor Bugbot for commit abebc3f. This will update automatically on new commits. Configure here.