fix(analyse_prometheus): store errors instead of exit #3052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I thought this was supposed to be a new version of 3051? It's entirely different though. |
Yes, this is a new enhancement actually: grafana/cortex-tools#237 Some analyzes takes a few hours. And immediate exit during the analysis decreases the overall UX. |
pracucci
reviewed
Sep 27, 2022
Fixes: grafana/cortex-tools#236 Signed-off-by: Furkan <[email protected]>
Dentrax
force-pushed
the
fix/query-error-log
branch
from
32d7a03 to
2ef7544
Compare
pracucci
approved these changes
Sep 27, 2022
sysedwinistrator
pushed a commit
to sysedwinistrator/mimir
that referenced
this pull request
Nov 21, 2022
Fixes: grafana/cortex-tools#236 Signed-off-by: Furkan <[email protected]> Signed-off-by: Furkan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: grafana/cortex-tools#236
Signed-off-by: Furkan [email protected]
What this PR does
Previous PR: grafana/cortex-tools#237
Which issue(s) this PR fixes or relates to
Fixes grafana/cortex-tools#236
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]cc @aknuds1