Skip to content

Add ability to include extra headers in HTTP responses. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to include extra headers in HTTP responses. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions node_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@ package main

import (
"fmt"
"github.com/prometheus/common/promlog"
"github.com/prometheus/common/promlog/flag"
"net/http"
_ "net/http/pprof"
"os"
"sort"

"github.com/prometheus/common/promlog"
"github.com/prometheus/common/promlog/flag"

"github.com/go-kit/kit/log"
"github.com/go-kit/kit/log/level"
"github.com/prometheus/client_golang/prometheus"
Expand All @@ -43,14 +44,16 @@ type handler struct {
includeExporterMetrics bool
maxRequests int
logger log.Logger
extraHeaders map[string]string
}

func newHandler(includeExporterMetrics bool, maxRequests int, logger log.Logger) *handler {
func newHandler(includeExporterMetrics bool, maxRequests int, logger log.Logger, extraHeaders map[string]string) *handler {
h := &handler{
exporterMetricsRegistry: prometheus.NewRegistry(),
includeExporterMetrics: includeExporterMetrics,
maxRequests: maxRequests,
logger: logger,
extraHeaders: extraHeaders,
}
if h.includeExporterMetrics {
h.exporterMetricsRegistry.MustRegister(
Expand All @@ -68,6 +71,10 @@ func newHandler(includeExporterMetrics bool, maxRequests int, logger log.Logger)

// ServeHTTP implements http.Handler.
func (h *handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
for k, v := range h.extraHeaders {
w.Header().Add(k, v)
}

filters := r.URL.Query()["collect[]"]
level.Debug(h.logger).Log("msg", "collect query:", "filters", filters)

Expand Down Expand Up @@ -157,6 +164,10 @@ func main() {
"web.config",
"Path to config yaml file that can enable TLS or authentication.",
).Default("").String()
extraHeaders = kingpin.Flag(
"web.extra-headers",
"Additional headers to add to HTTP responses. Can be repeated.",
).StringMap()
)

promlogConfig := &promlog.Config{}
Expand All @@ -169,8 +180,12 @@ func main() {
level.Info(logger).Log("msg", "Starting node_exporter", "version", version.Info())
level.Info(logger).Log("msg", "Build context", "build_context", version.BuildContext())

http.Handle(*metricsPath, newHandler(!*disableExporterMetrics, *maxRequests, logger))
http.Handle(*metricsPath, newHandler(!*disableExporterMetrics, *maxRequests, logger, *extraHeaders))
http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
for k, v := range *extraHeaders {
w.Header().Add(k, v)
}

w.Write([]byte(`<html>
<head><title>Node Exporter</title></head>
<body>
Expand Down