-
Notifications
You must be signed in to change notification settings - Fork 35
renovate: when bumping grafana packages add release label #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
01efc02 to
2dd1789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm @jackw are you sure you can add labels to custom managers? I think you need to move the labels to the associated package rule (line 41-53), but I could be wrong.
Thanks @sunker . You are correct! I've moved it as suggested! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments are really helpful, thanks for doing this! Even though it's pretty self-explanatory perhaps you can add a comment also to the github actions rule (the last one)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work on adding those comments 🎉
What this PR does / why we need it:
Without a
releaselabel on the PRs that bump plugin-e2e in the create-plugin package.json template we don't get updates for plugin-e2e trickling down to plugins which rely on create-plugin update to bump deps which can leave canary e2e tests in a broken state even after fixes have been merged.This Pr adds the missing label to resolve the above issue.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: