Skip to content

Conversation

@jackw
Copy link
Collaborator

@jackw jackw commented Sep 12, 2025

What this PR does / why we need it:
Without a release label on the PRs that bump plugin-e2e in the create-plugin package.json template we don't get updates for plugin-e2e trickling down to plugins which rely on create-plugin update to bump deps which can leave canary e2e tests in a broken state even after fixes have been merged.

This Pr adds the missing label to resolve the above issue.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw self-assigned this Sep 12, 2025
@jackw jackw requested review from a team as code owners September 12, 2025 13:21
@jackw jackw added the no-changelog Don't include in changelog and version calculations label Sep 12, 2025
@jackw jackw requested a review from leventebalogh September 12, 2025 13:21
@jackw jackw added the ci label Sep 12, 2025
@jackw jackw requested review from andresmgot, s4kh and xnyo September 12, 2025 13:21
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

@jackw jackw force-pushed the jackw/fix-plugin-e2e-renovate-label branch from 01efc02 to 2dd1789 Compare September 12, 2025 13:54
@tolzhabayev tolzhabayev moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Sep 12, 2025
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm @jackw are you sure you can add labels to custom managers? I think you need to move the labels to the associated package rule (line 41-53), but I could be wrong.

@jackw
Copy link
Collaborator Author

jackw commented Sep 17, 2025

Hmm @jackw are you sure you can add labels to custom managers? I think you need to move the labels to the associated package rule (line 41-53), but I could be wrong.

Thanks @sunker . You are correct!

npx --yes --package renovate -- renovate-config-validator
 INFO: Validating .github/renovate.json5
ERROR: Found errors in configuration
       "file": ".github/renovate.json5",
       "errors": [
         {
           "topic": "Configuration Error",
           "message": "Custom Manager contains disallowed fields: labels"
         }
       ]

I've moved it as suggested!

Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments are really helpful, thanks for doing this! Even though it's pretty self-explanatory perhaps you can add a comment also to the github actions rule (the last one)?

Copy link
Contributor

@hugohaggmark hugohaggmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work on adding those comments 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci no-changelog Don't include in changelog and version calculations

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

4 participants