Skip to content

Conversation

@jackw
Copy link
Collaborator

@jackw jackw commented Oct 24, 2025

What this PR does / why we need it:

LTS day is almost upon us. This PR updates plugin-e2e's engines to drop support for node 18 and include support for node 24.

Marking it as a major breaking change given we're dropping support for node 18, which is end of life.

Which issue(s) this PR fixes:

Fixes #2107

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install [email protected]
npm install @grafana/[email protected]
# or 
yarn add [email protected]
yarn add @grafana/[email protected]

@jackw jackw self-assigned this Oct 24, 2025
@Copilot Copilot AI review requested due to automatic review settings October 24, 2025 09:00
@jackw jackw requested a review from a team as a code owner October 24, 2025 09:00
@jackw jackw added the major Increment the major version when merged label Oct 24, 2025
@jackw jackw requested a review from a team as a code owner October 24, 2025 09:00
@jackw jackw added the release Create a release when this pr is merged label Oct 24, 2025
@jackw jackw requested a review from sunker October 24, 2025 09:00
@jackw jackw added the plugin-e2e related to the plugin-e2e package label Oct 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Node.js version requirements for the plugin-e2e package to align with current LTS support, dropping Node 18 (which has reached end of life) and adding support for Node 24.

Key Changes:

  • Updated the engines.node field to require Node 20 or higher (up to Node 24)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new major release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Oct 24, 2025
@github-actions
Copy link
Contributor

Playwright test results

Image Name Version Result Report
grafana-dev 12.3.0-18773734011
grafana-enterprise 12.2.1
grafana-enterprise 11.5.10
grafana-enterprise 10.3.12
grafana-enterprise 9.3.16
grafana-enterprise 8.5.27
Troubleshooting

404 when clicking on View report

By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:

  1. Go to the Settings tab of your repository.
  2. In the left-hand sidebar, click on Pages.
  3. Under Source, select Deploy from a branch, then choose the gh-pages branch.

This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major Increment the major version when merged plugin-e2e related to the plugin-e2e package release Create a release when this pr is merged

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

Feat: Support Node 24

2 participants