Skip to content

chore: Update envVar configuration to support custom envs #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

cesarokuti
Copy link

To support IPv6 clusters, we need to configure the MY_POD_IP environment variable using the valueFrom structure. Therefore, I suggest changing the extraEnvs field to allow an open configuration instead of using a predefined range.

Additionally, I've included the self-profile configuration to be managed as part of this update.

@cesarokuti cesarokuti requested a review from a team as a code owner June 26, 2025 14:22
@CLAassistant
Copy link

CLAassistant commented Jun 26, 2025

CLA assistant check
All committers have signed the CLA.

@korniltsev
Copy link
Collaborator

Can you use extraEnvFrom instead?

Is this a breaking change? Can we make it non-breaking change ?

Signed-off-by: Cesar Okuti <[email protected]>
Signed-off-by: Cesar Okuti <[email protected]>
@cesarokuti
Copy link
Author

Can you use extraEnvFrom instead?

Is this a breaking change? Can we make it non-breaking change ?

I created other parameter to configure this env. But I think we can deprecate in the future.

@korniltsev korniltsev self-assigned this Jul 30, 2025
@korniltsev korniltsev requested a review from Copilot July 30, 2025 05:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Helm chart configuration to support more flexible environment variable management for IPv6 cluster compatibility and self-profiling control. The changes enable custom environment variable configurations using the valueFrom structure, which is needed for setting MY_POD_IP in IPv6 environments.

  • Added configurable self-profiling disable option through disableSelfProfile parameter
  • Introduced extraCustomEnvVars field for flexible environment variable configuration
  • Updated chart version to reflect the configuration changes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
values.yaml Adds disableSelfProfile and extraCustomEnvVars configuration options
deployments-statefulsets.yaml Updates template to use configurable self-profiling and apply custom environment variables
README.md Documents the new configuration parameters
Chart.yaml Increments chart version to reflect changes

Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore my other comments above.
The changes looks good to me. Please update an example and resolve conflicts and we will merge this

- Remove some quotes in a bool env;
- Change envVar custom field
@cesarokuti cesarokuti requested a review from korniltsev August 7, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants