feat: Make the minStepDuration of the querier configurable per tenant from limits configuration #4540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luweglarz
force-pushed
the
config-querier-min-interval
branch
from
9c07baf to
72aa99c
Compare
|
I am not sure with the naming of the field, maybe something more clear would be better like seriesMinInterval, what do you think @simonswine ? |
simonswine
reviewed
Oct 20, 2025
There was a problem hiding this comment.
Thank you for your PR.
I think it would be preferred, if we could configure this a per tenant basis.
For this we typically add a field to the "limit" struct, this has the benefit, that we can change the value on a per tenant basis and also update it without restarting the pyroscope process, here is the related struct:
pyroscope/pkg/validation/limits.go
Line 37 in 5b02fdd
Let me know if you have any questions
luweglarz
force-pushed
the
config-querier-min-interval
branch
from
b364e88 to
9d94175
Compare
luweglarz
force-pushed
the
config-querier-min-interval
branch
2 times, most recently
from
9d94175 to
930de2f
Compare
|
I applied your suggestions @simonswine |
luweglarz
changed the title
…limits configuration
luweglarz
force-pushed
the
config-querier-min-interval
branch
from
03cd455 to
d23c6bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #4524
Add a way to configure the minInterval in the querier configuration for series graph between each point