Get Faro App Values from Config and Add Namespace App Value#222
Closed
SeamusGrafana wants to merge 1 commit intomainfrom
Closed
Get Faro App Values from Config and Add Namespace App Value#222SeamusGrafana wants to merge 1 commit intomainfrom
SeamusGrafana wants to merge 1 commit intomainfrom
Conversation
DefCon-007
approved these changes
Jul 16, 2025
Collaborator
|
closed in favour of #226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Faro Config to get the Faro App Values from the Config Endpoint (which used Env vars) and use those, falling back to default values (previously used)
It also adds a Namespace App Value to use as well, for better correlation of Traces.