Skip to content

Conversation

juliajohannesen
Copy link
Contributor

#1036 is currently stuck on some CI jobs as a result of CodeQL, pre-commit, and Zizmor not working when the PR author is github-actions[bot]. This PR allows them to be skipped in that case, but adds policy-bot to enforce that.

One question is if any work needs to be done to apply the same restrictions laid out in this part of our terraform config for this repository.

@juliajohannesen juliajohannesen requested a review from a team as a code owner August 15, 2025 20:00
@zerok
Copy link
Contributor

zerok commented Aug 20, 2025

I'm slightly confused as to why these workflows aren't triggered. At least the codeql one has ready_for_review as trigger but the others don't. Wouldn't it be easier to just add that trigger there too?

@juliajohannesen
Copy link
Contributor Author

I assume for the same reason as github/codeql-action#2858? Unless that's specific to dependabot.

@zerok
Copy link
Contributor

zerok commented Aug 26, 2025

That's the point of having these release PRs marked as draft first. Then someone goes in and moves them to "ready for review" and the jobs should be triggered 🙂

@juliajohannesen
Copy link
Contributor Author

I'm pretty sure it was still waiting on CodeQL to pass even after the actions ran via ready_for_review- presumably because they're integrated as part of the platform?

@guicaulada
Copy link
Contributor

guicaulada commented Aug 28, 2025

Hey, I think Horst has a point here, if adding the ready_for_review trigger to all actions would work then I think that's a better approach.

Currently, only the pre-commit workflow is not running when we "undraft" the PR.

CodeQL and other workflows would run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants