Tempo v2.7.2 with distributor ingester fix#5295
Closed
carles-grafana wants to merge 2 commits intografana:release-v2.7from
Closed
Tempo v2.7.2 with distributor ingester fix#5295carles-grafana wants to merge 2 commits intografana:release-v2.7from
carles-grafana wants to merge 2 commits intografana:release-v2.7from
Conversation
* Fix distributor rebatch bug, by not using a 32-bit hash for deduping, only for ring sharding (as required) * lint * changelog
* ingester: use a 64-bit hash to avoid collisions We had this issue in the distributor, it it can happen in the ingester too with live traces. * Update changelog * Add test for live traces collision
carles-grafana
force-pushed
the
tempo_v2.7.2_with_distributor_ingester_fix
branch
from
174269c to
a1f5dcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]