Update metrics-from-traces docs for v3.0#6644
Conversation
mapno
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
knylander-grafana,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
javiermolinar
left a comment
javiermolinar
left a comment
There was a problem hiding this comment.
There are more localblocks references:
docs/sources/tempo/metrics-from-traces/metrics-generator/_index.md
Outdated
Show resolved
Hide resolved
| - Span metrics | ||
| - Local blocks | ||
|
|
||
| <p align="center"><img src="tempo-metrics-gen-overview.svg" alt="Service metrics architecture"></p> |
There was a problem hiding this comment.
Do we need to update the diagram?
There was a problem hiding this comment.
It's very high level, nothing changes.
|
|
||
| <!-- Using a custom admonition because no feature flag is required. --> | ||
|
|
||
| {{< docs/shared source="tempo" lookup="traceql-metrics-admonition.md" version="<TEMPO_VERSION>" >}} |
There was a problem hiding this comment.
Oh! Remove this because TraceQL metrics goes GA? If so, we should search through all of the docs for this line and make sure it's deleted. We'll have to do the same for cloud docs when the time is right.
There was a problem hiding this comment.
Looks like you did that. We'll just have to do clean up in the Cloud docs at the appropriate time.
There was a problem hiding this comment.
Once we have the docs/shared line removed from the Cloud docs, we can delete the shared file (docs/sources/tempo/shared/traceql-metrics-admonition.md).
| - Configure a Tempo data source in Grafana or Grafana Cloud ([documentation](/docs/grafana/<GRAFANA_VERSION>/datasources/tempo/configure-tempo-data-source/)) | ||
| - Access Grafana Cloud or Grafana version 10.4 or later | ||
|
|
||
| Refer to the [Metrics-generator configuration](http://grafana.com/docs/tempo/<TEMPO_VERSION>/configuration/#metrics-generator) documentation for more information about the `metrics-generator` configuration. |
There was a problem hiding this comment.
Does this mean we won't have to have local block processor set up any where for TraceQL metrics? if so, we'll need to do a check through all of the docs for any place local blocks is mentioned.
There was a problem hiding this comment.
Again, this is one of the things we'll have to check in Grafana Cloud Traces docs.
There was a problem hiding this comment.
Yes, local-blocks is completely gone. Poof!
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Good job! Thank you for updating this!
These are updated in 3.0-docs or reference upgrading from previous versions. I think it's correct. |
3 participants
What this PR does:
Update metrics-from-traces docs for v3.0
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/tempo-squad/issues/1082
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]