Supported HMR in Vite RSC example #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When vite hmr happens the state navigator can change - if editing a route in the config, for example. So the NavigationHandler needs to rerender with the new state navigator. Will need to test if this actually works outside of hmr - will add unit tests and see
If edit the state navigator route config twice in a row then the 2nd time vite rerenders the NavigationProvider from scratch with the new url bug the old stateNavigator - only temporarily, it then renders it with the new stateNavigator. So caught the error and prevented SceneRSCView throwing when there's empty state context.
Copied files over from parcel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the people list edit the route in
stateNavigator.tsxand the hyperlinks should all update but didn't. Vite HMR creates a newstateNavigatorand theNavigationHandlerdidn't handle it. It doesn't expect thestateNavigatorprop to ever change. UpdatedNavigationHandlerto change the navigation context when the prop changes and the HMR works and updates the hyperlinks.However there is a Vite HMR bug that happens if edit the route a second time. Vite HMR calls the
NavigationProviderwith the latest url but the oldstateNavigator. It throws trying to parse the latest url. Wrapped thenavigateLinkcall in a try/catch and this works because eventually Vite HMR calls with the lateststateNavigator. Will raise on Vite and see what they say.