This repository was archived by the owner on Mar 13, 2025. It is now read-only.
remove groovyVersion from gradle.properties #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrei
approved these changes
Mar 3, 2025
Contributor
matrei
left a comment
matrei
left a comment
There was a problem hiding this comment.
grailsVersion and grailsGradlePluginVersion are still at M. Should we go back to SNAPSHOT to see that nothing breaks?
Contributor
Author
|
Rerunning CI now. There were 4 milestone versions. |
Contributor
|
Hmm, we are not using the BOM as much as we can in this repo. Should we fix that before M3? |
Contributor
Author
|
I'll make the grails-bom changes in the PR. |
jdaugherty
reviewed
Mar 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groovyVersion = System.getenv('CI_GROOVY_VERSION')is still used in the joint workflow, but reads from the groovy git repository.