feat(cli): Use esm modules over commonjs#2324
Closed
spotandjake wants to merge 3 commits intograin-lang:mainfrom
Closed
feat(cli): Use esm modules over commonjs#2324spotandjake wants to merge 3 commits intograin-lang:mainfrom
spotandjake wants to merge 3 commits intograin-lang:mainfrom
Conversation
spotandjake
added
the
admin
spotandjake
requested review from
marcusroberts,
ospencer and
phated
as code owners
ospencer
reviewed
Oct 30, 2025
ospencer
reviewed
Oct 30, 2025
spotandjake
force-pushed
the
spotandjake-esm
branch
from
91b0d5a to
db8283d
Compare
Member
Author
|
I needed to update prettier in order to run the formatter but while I was there I figured I should update the other dependencies in the cli, Happy to split that into a seperate pr if wanted. |
Member
|
Yeah, I think we should split that. |
spotandjake
force-pushed
the
spotandjake-esm
branch
from
db8283d to
b3ce8f1
Compare
Member
Author
|
Alright I just update prettier in this pr and I'll update the others in a seperate pr later. |
Member
Author
|
Closing as it doesn't look like we can make this change with pkg just yet sadly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small pr switching from
requiretoimportin the cli, I figure we might as well switch to esm given we are on a version of node that supports it.Draft as I would still like to test the js build, but it takes forever locally.