feat(compiler): Upgrade to Binaryen v124#2333
Merged
ospencer merged 2 commits intograin-lang:mainfrom Nov 14, 2025
Merged
Conversation
spotandjake
force-pushed
the
spotandjake-binaryen-124
branch
5 times, most recently
from
be1efcb to
0cab29c
Compare
spotandjake
commented
Nov 12, 2025
spotandjake
commented
Nov 12, 2025
spotandjake
force-pushed
the
spotandjake-binaryen-124
branch
from
0cab29c to
7583c71
Compare
spotandjake
requested review from
alex-snezhko,
marcusroberts,
ospencer,
peblair and
phated
as code owners
spotandjake
force-pushed
the
spotandjake-binaryen-124
branch
from
7583c71 to
f20e746
Compare
spotandjake
force-pushed
the
spotandjake-binaryen-124
branch
from
7299393 to
7caf96c
Compare
spotandjake
commented
Nov 13, 2025
| "copy:js": "cp -f #{$GRAINC_JS_PATH} #{$GRAINDOC_JS_PATH} #{$GRAINFORMAT_JS_PATH} #{$GRAINLSP_JS_PATH} #{$CLI_BIN_DIR}", | ||
| "clean": "rm -rf #{self.root}/_esy", | ||
| "build:js": "esy b dune build @js --no-buffer #{os == 'windows' ? '-j 2' : ''}", | ||
| "build:js": "esy b dune build @js --no-buffer -j 2", |
Member
Author
There was a problem hiding this comment.
I lowered the number of builders as we were running into out-of-memory issues when building on Ubuntu, likely because binaryen has grown.
I decided to lower on all platforms because I noticed that we were actually building faster with fewer workers, even on macOS where there was enough RAM available, likely do to less memory pressure, causing less swap usage. I noticed similar behaviour when building locally previously. I saw macos build times go from ~24minutes to ~15minutes
I went with 2 as it's what we were using on Windows previously; however, it may make sense to play with this number a little more in a separate pr for optimum performance.
ospencer
approved these changes
Nov 13, 2025
ospencer
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades to binaryen.ml v124.