feat(lsp): Support displaying multiple errors in the lsp#2354
Merged
ospencer merged 2 commits intograin-lang:mainfrom Feb 8, 2026
Merged
feat(lsp): Support displaying multiple errors in the lsp#2354ospencer merged 2 commits intograin-lang:mainfrom
ospencer merged 2 commits intograin-lang:mainfrom
Conversation
This pr adds support for displaying multiple well formedness errors in the lsp, this is a follow up pr to grain-lang#2348 . The way I implemented this was to keep a list of all reported errors and then we can go through the list when one is raised. I think whenever we complete grain-lang#2342 we may want to streamline the error tracking api a little to handle this better but this should work as a good solution for now. Closes: grain-lang#2353
spotandjake
requested review from
alex-snezhko,
marcusroberts,
ospencer,
peblair and
phated
as code owners
ospencer
reviewed
Feb 8, 2026
Member
Author
|
Applied those changes |
ospencer
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds support for displaying multiple well formedness errors in the lsp, this is a follow up pr to #2348. The way I implemented this was to keep a list of all reported errors and then we can go through the list when one is raised. I think whenever we complete #2342 we may want to streamline the error tracking api a little to handle this better but this should work as a good solution for now.
Demo Screenshot:
Closes: #2353