feat(lsp): Implement an add graindoc code action#2356
Open
spotandjake wants to merge 3 commits intograin-lang:mainfrom
Open
feat(lsp): Implement an add graindoc code action#2356spotandjake wants to merge 3 commits intograin-lang:mainfrom
spotandjake wants to merge 3 commits intograin-lang:mainfrom
Conversation
1d07c69 to
8be2044
Compare
Member
Author
|
Tests have been added Just some notes in response to the community call:
|
spotandjake
commented
Feb 11, 2026
| [ | ||
| ( | ||
| lsp_range( | ||
| (1, 4611686018427387871), |
Member
Author
There was a problem hiding this comment.
I wasn't quite sure if this is worthy of a code commnt, but this number should be Int.max_int however it seems that yojson treats these internally as IEEE-754 and we are getting some rounding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr implements an add graindoc code action that lets you add a graindoc template to
let expressionsandmodules.by default for a value or module we add:
and for a function we add:
This pr isn't quite ready to merge as it still needs tests but I wanted to get some feedback on this before writing those.
Closes: #2301