chore(stdlib): Use byte literals to test String.encode#2363
Merged
ospencer merged 1 commit intograin-lang:mainfrom Mar 1, 2026
Merged
chore(stdlib): Use byte literals to test String.encode#2363ospencer merged 1 commit intograin-lang:mainfrom
String.encode#2363ospencer merged 1 commit intograin-lang:mainfrom
Conversation
pixilcode
requested review from
alex-snezhko,
marcusroberts,
ospencer,
peblair,
phated and
spotandjake
as code owners
Member
|
Looks great! I approved the CI to run and as long as that's set this is good to go. |
spotandjake
reviewed
Feb 26, 2026
Member
spotandjake
left a comment
spotandjake
left a comment
There was a problem hiding this comment.
Code itself looks good to me, though I think you may need to run the formatter on the file.
grain format ./compiler/test/stdlib/string.test.gr -o ./compiler/test/stdlib/string.test.gr
Contributor
Author
|
Okay, sweet! I ran the formatter and updated the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare the output of
String.encodedirectly to byte literals, rather than usingprocessBytesto compare to an array of bytes.Resolves #2362 .