chore: do not share data between memory sessions#13
Merged
KnorpelSenf merged 7 commits intogrammyjs:mainfrom Jan 23, 2026
Merged
chore: do not share data between memory sessions#13KnorpelSenf merged 7 commits intogrammyjs:mainfrom
KnorpelSenf merged 7 commits intogrammyjs:mainfrom
Conversation
KnorpelSenf
reviewed
Nov 10, 2025
Member
KnorpelSenf
left a comment
KnorpelSenf
left a comment
There was a problem hiding this comment.
Is there a reason to avoid structuredClone?
KnorpelSenf
reviewed
Nov 10, 2025
KnorpelSenf
changed the title
LWJerri
changed the title
KnorpelSenf
reviewed
Jan 23, 2026
Member
|
oops |
KnorpelSenf
reviewed
Jan 23, 2026
Member
KnorpelSenf
left a comment
KnorpelSenf
left a comment
There was a problem hiding this comment.
It's certainly an interesting decision to clone all values passed to the storage adapter, too. #4 only mentions memory sessions because they live in RAM and traditionally share data between requests. Usually, I'd expect persistent storage adapters to serialise the data anyway, making your cloning redundant.
What was the reason for this decision?
KnorpelSenf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4