fix(utils): bump grammy to 1.35.0 and update botInfo type#264
Open
arunr-inji wants to merge 1 commit intogrammyjs:mainfrom
Open
fix(utils): bump grammy to 1.35.0 and update botInfo type#264arunr-inji wants to merge 1 commit intogrammyjs:mainfrom
arunr-inji wants to merge 1 commit intogrammyjs:mainfrom
Conversation
grammy@1.35.0 added two required fields to UserFromGetMe: can_connect_to_business and has_main_web_app. Updated the botInfo object in createBot() accordingly. This fixes a version mismatch between storage-utils (1.21.1) and packages like redis (1.35.0), which caused session middleware to throw "Cannot access session data because this update does not belong to a chat".
arunr-inji
force-pushed
the
fix/bump-storage-utils-grammy
branch
from
face278 to
31e3c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@grammyjs/storage-utils was pinned to grammy 1.21.1 while some packages (e.g. redis) had moved to 1.35.0. This mismatch caused the redis node tests to fail (#2 in #262)
Bumped grammy in storage-utils to 1.35.0 and updated createBot() to include the two fields that grammy added to UserFromGetMe in that version: can_connect_to_business and has_main_web_app.
Note: the pnpm-lock.yaml diff is large but mostly quote style formatting from pnpm v10 — the only real dependency change is the grammy version for storage-utils.
CI Failures on this branch are due to:
Before fix (on main branch) - @grammyjs/storage-redis:test fails:
After fix (on this branch) - @grammyjs/storage-redis:test succeeds. The failing test is a separate issue - due to a dependency on better-sqlite3
