Skip to content

Optimize Dockerfile #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghorbani-ali wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Optimize Dockerfile #480

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ea3de9
Change SDK base image to alpine
ghorbani-ali Apr 7, 2024
2de2443
Replace dynamic plugin build
ghorbani-ali Apr 7, 2024
268d70f
Remove unnecessary restore command
ghorbani-ali Apr 7, 2024
dcf1534
Cahnge runtime base image to alpine
ghorbani-ali Apr 7, 2024
b7c7f91
Merge branch 'main' into optimize-dockerfile
ghorbani-ali May 4, 2024
9e58ad3
Update Dockerfile
ghorbani-ali May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build stage
FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build-env
FROM mcr.microsoft.com/dotnet/sdk:8.0-alpine AS build-env
LABEL stage=build-env
WORKDIR /app

Expand All @@ -9,16 +9,19 @@ COPY ./src/ /app/
ARG GIT_COMMIT
ARG GIT_BRANCH

# Build plugins
# build plugins
RUN for plugin in /app/Plugins/*; do \
dotnet build "$plugin" -c Release -p:SourceRevisionId=$GIT_COMMIT -p:GitBranch=$GIT_BRANCH; \
done

#build
RUN dotnet build /app/Web/Grand.Web/Grand.Web.csproj --no-restore -c Release -p:SourceRevisionId=$GIT_COMMIT -p:GitBranch=$GIT_BRANCH

Comment on lines +17 to +19
Copy link
Contributor

@GuyPago GuyPago Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe dotnet publish also builds the project. Why is this step needed?

# Publish Web project
RUN dotnet publish /app/Web/Grand.Web/Grand.Web.csproj -c Release -o ./build/release -p:SourceRevisionId=$GIT_COMMIT -p:GitBranch=$GIT_BRANCH

# Runtime stage
FROM mcr.microsoft.com/dotnet/aspnet:8.0 AS runtime
FROM mcr.microsoft.com/dotnet/aspnet:8.0-alpine AS runtime
EXPOSE 8080
WORKDIR /app
COPY --from=build-env /app/build/release .
Expand Down