Skip to content

Conversation

@KrzysztofPajak
Copy link
Member

No description provided.

@KrzysztofPajak KrzysztofPajak requested a review from Copilot June 9, 2025 18:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the product review management functionality across both store and admin areas. Key changes include the introduction of new endpoints and views for listing, editing, and managing product reviews, updates to service interfaces with default parameters for store IDs, and an update to permissions to include product review management.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Web/Grand.Web.Store/Controllers/ProductReviewController.cs Adds new actions for listing, editing, approving/disapproving, and deleting product reviews with store validation.
src/Web/Grand.Web.Store/Areas/Store/Views/ProductReview/Partials/CreateOrUpdate.cshtml Introduces a partial view for creating/updating product reviews.
src/Web/Grand.Web.Store/Areas/Store/Views/ProductReview/List.cshtml Implements the Kendo UI grid and JavaScript logic for displaying and managing product reviews.
src/Web/Grand.Web.Store/Areas/Store/Views/ProductReview/Edit.cshtml Provides the main view for editing product review details.
src/Web/Grand.Web.AdminShared/Services/ProductReviewViewModelService.cs Adjusts service methods to use default parameters for store IDs.
src/Web/Grand.Web.AdminShared/Interfaces/IProductReviewViewModelService.cs Updates interfaces to reflect changes in service method signatures.
src/Web/Grand.Web.Admin/Controllers/ProductReviewController.cs Removes redundant store manager checks, streamlining admin actions.
src/Modules/Grand.Module.Installer/Extensions/PermissionExtensions.cs Adds new product review management permission to installer defaults.
Comments suppressed due to low confidence (1)

src/Web/Grand.Web.Store/Controllers/ProductReviewController.cs:104

  • The anonymous object passed to RedirectToAction is missing a property name for productReview.ProductId. It should be formatted as 'new { id = productReview.Id, ProductId = productReview.ProductId }' to ensure proper parameter binding.
return continueEditing ? RedirectToAction("Edit", new { id = productReview.Id, productReview.ProductId }) : RedirectToAction("List");

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

@KrzysztofPajak KrzysztofPajak merged commit b675cc7 into develop Jun 9, 2025
6 checks passed
@KrzysztofPajak KrzysztofPajak deleted the feature/sas-product-review branch June 9, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants