Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st OSS PR, go easy on me!
Thanks for this package, I started out rolling my own validation for various phone numbers and swiftly realised this was a large task to undertake for i18n. If you consider the proposed idea below worthwhile and it's not quite there yet, let me know, I'm happy to make edits.
Problem:
Lack of type safety on available country codes. More than one type of one country code list exists, e.g. alpha-3, but only one is supported.
Proposed solution:
Adding the list of country codes as an exposed type for consumers of the package
Other:
All tests are passing
Adhered to the existing lint practices
@grantila