Fix breaking changes in getAsYouType#138
Open
BjornTheProgrammer wants to merge 1 commit intograntila:masterfrom
Open
Fix breaking changes in getAsYouType#138BjornTheProgrammer wants to merge 1 commit intograntila:masterfrom
BjornTheProgrammer wants to merge 1 commit intograntila:masterfrom
Conversation
BjornTheProgrammer
force-pushed
the
master
branch
from
82e7f7c to
81df231
Compare
BjornTheProgrammer
force-pushed
the
master
branch
from
81df231 to
faa46a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130. Some api changes caused the difference in output between 7.2.0 and 7.3.0. These persist still in v7.5.0.
I've just referenced the logic in v7.2.0 and adjusted it to match more closely in the current code base, and that fixed the issue.
The reproduction I posted in #130 was actually incorrect. I've fixed the reproduction steps.
The only other consideration is that the error is still output in the new version. I don't think that matters.