Environment and Testing Updates #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelban
reviewed
Jan 9, 2025
Contributor
There was a problem hiding this comment.
I would kindly suggest not including .env.example in the .gitignore file.
The .env.example file serves as a helpful reference for environment variables, allowing developers to understand the required configuration for the project. Since it doesn’t contain sensitive information, it is safe to keep it in the repository. Adding it to .gitignore may limit its usefulness as a guide for the team.
For better collaboration and clarity, it’s recommended to keep .env.example in the repository.
Owner
Author
There was a problem hiding this comment.
Ah my bad! I meant to add .env only but let .env.example slipped in. Sorry! I will revert it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made: 1. Updated virtual environment setup: - Changed venv name to venv - Updated .gitignore to include venv and environment files - Removed py310 from .gitignore 2. Improved LLM functionality: - Switched default OpenAI model to GPT-4o - Added comprehensive unit tests for environment loading and LLM operations. All tests are passing and the environment setup is now more standardized.