Render accumulation (allow custom background blending)#35
Open
jkulhanek wants to merge 1 commit intographdeco-inria:mainfrom
Open
Render accumulation (allow custom background blending)#35jkulhanek wants to merge 1 commit intographdeco-inria:mainfrom
jkulhanek wants to merge 1 commit intographdeco-inria:mainfrom
Conversation
|
I tried this fork and it worked great. But I made a mistake: I assumed that gradients with respect to "accumulation" would flow correctly, but that was not the case since backward wasn't implemented -- so I got, silently, the wrong gradients. Would it be helpful to add an error/warning or implement the backward pass? |
|
Thanks for your brilliant work. Does the original version not support a custom background? Is there any document explain it? |
|
Hello ! |
|
I think this PR does not implement backward pass. I can forward "accumulation" but I could see no grad in backward pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enabled accumulation to be rendered and returned.