Ensure all tensors in GaussianRasterizer's raster_settings are on the same device#65
Open
davidliyutong wants to merge 1 commit intographdeco-inria:mainfrom
Open
Conversation
… same device - Added _sanitizeSettings method in GaussianRasterizer class - Check if all tensors in raster_settings are on the same device - Raise an exception if tensors are on different devices - Raise an exception if any tensor is on the CPU, requiring the use of a CUDA device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing raster_settings to
GaussianRasterizationSettings, beginners are very likely to forget to copy.bgand.viewmatrixto CUDA devices, leading to hard-to-debugCUDA illegal memory accessissues. Therefore I believe a _sanitizeSettings should be added to throw a clear exception if the tensors are misplaced.Here is a summary of this commit: