Move current location inside input #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot on an autosuggest item
…ls unnatural; fix bug when 'ESC' is pressed
karussell
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408.
It also improves the code as it removes a workaround (
myMarkerRef) and consistently calls e.preventDefault for all the buttons like clear, close, current locations and autocomplete to avoid that the onBlur causes the input to lose the focus and then hide the button, which would make a click impossible. Furthermore there is no longer code in onBlur that depends on isSmallScreen.This also fixes a bug in current master for the mobile view:
Also ensure that: