Skip to content

Don't force HTTPS in local dev #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AprilArcus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't force HTTPS in local dev #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions @app/server/src/middleware/installHelmet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ if (!tmpRootUrl || typeof tmpRootUrl !== "string") {
}
const ROOT_URL = tmpRootUrl;

const isDevOrTest =
process.env.NODE_ENV === "development" || process.env.NODE_ENV === "test";
const isDev = process.env.NODE_ENV === "development";
const isTest = process.env.NODE_ENV === "test";

export default async function installHelmet(app: Express) {
const { default: helmet, contentSecurityPolicy } = await import("helmet");
Expand All @@ -28,22 +28,31 @@ export default async function installHelmet(app: Express) {
},
},
};
if (isDevOrTest) {
// Appease TypeScript
if (
typeof options.contentSecurityPolicy === "boolean" ||
!options.contentSecurityPolicy
) {
throw new Error(`contentSecurityPolicy must be an object`);
}
// Appease TypeScript
if (
typeof options.contentSecurityPolicy === "boolean" ||
!options.contentSecurityPolicy
) {
throw new Error(`contentSecurityPolicy must be an object`);
}
if (isDev) {
// Disable HSTS in dev so browsers don't cache "always use HTTPS" for localhost
options.hsts = false;

// Remove upgrade-insecure-requests in dev — it causes browsers to upgrade
// subresource requests to HTTPS even when the server only speaks HTTP.
options.contentSecurityPolicy.directives!["upgrade-insecure-requests"] =
null;
}
if (isDev || isTest) {
// Dev needs 'unsafe-eval' due to
// https://github.com/vercel/next.js/issues/14221
options.contentSecurityPolicy.directives!["script-src"] = [
"'self'",
"'unsafe-eval'",
];
}
if (isDevOrTest || !!process.env.ENABLE_GRAPHIQL) {
if (isDev || isTest || !!process.env.ENABLE_GRAPHIQL) {
// Enables prettier script and SVG icon in GraphiQL
options.crossOriginEmbedderPolicy = false;
}
Expand Down