Skip to content

refactor: Add an timeout object to timer return type #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Add an timeout object to timer return type #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/common-ts/src/eventual/__tests__/eventual.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ describe('Eventual', () => {
})

test('Join (timer)', async () => {
const ticker = timer(100)
const [intervalID, ticker] = timer(100)
const ticks = ticker.reduce(n => ++n, 0)
const ticksViaJoin = join({ ticker }).reduce(n => ++n, 0)

Expand All @@ -296,6 +296,7 @@ describe('Eventual', () => {
// we're happy
await expect(ticks.value()).resolves.toBeGreaterThan(5)
await expect(ticksViaJoin.value()).resolves.toBeGreaterThan(5)
clearInterval(intervalID)
})

test('Values (async generator)', async () => {
Expand Down
6 changes: 3 additions & 3 deletions packages/common-ts/src/eventual/eventual.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,10 +286,10 @@ export function throttle<T>(source: Eventual<T>, interval: number): Eventual<T>
return output
}

export function timer(milliseconds: number): Eventual<number> {
export function timer(milliseconds: number): [NodeJS.Timer, Eventual<number>] {
const time = mutable(Date.now())
setInterval(() => time.push(Date.now()), milliseconds)
return time
const intervalID = setInterval(() => time.push(Date.now()), milliseconds)
return [intervalID, time]
}

export function reduce<T, U>(
Expand Down