Skip to content

Conversation

drew-u410
Copy link
Contributor

  • Adds the ability to enable SSL for the database connection.
  • Maintains existing default behavior of not being enabled.
  • Adds tests for setting options and default options on the database connection.

--

Ran tests locally and they pass as expected:

$ POSTGRES_TEST_DATABASE=test POSTGRES_TEST_PASSWORD=test POSTGRES_TEST_USERNAME=test POSTGRES_TEST_HOST=localhost yarn test

Once this is merged, I intend to open PRs for graphprotocol/indexer to update if accepted.

Thank you.

Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the contribution, @drew-u410!

@drew-u410
Copy link
Contributor Author

LGTM 👍 Thanks for the contribution, @drew-u410!

Np- do you intend to merge? If so, on what timeline? I would like to prepare an indexer MR but I can't do so until this is able to be used.

@dwerner dwerner merged commit 73a972f into graphprotocol:master Oct 28, 2024
@dwerner
Copy link
Contributor

dwerner commented Oct 28, 2024

I've put up a version bump PR #122 which will include this.

@drew-u410
Copy link
Contributor Author

I've put up a version bump PR #122 which will include this.

Thank you very much. I have the indexer MR just about ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants