fix: resolve lint issues and centralize interface ID generation

Lint Fixes:
- Restore missing NatSpec documentation for IRewardsIssuer interface
- Remove TODO comment from MockIssuanceAllocator
- Add solhint-disable for named-parameters-mapping rule (not supported in Solidity 0.7.6)

Interface ID Centralization:
- Add IIssuanceAllocator and IRewardsEligibilityOracle to interfaces package InterfaceIdExtractor
- Update interfaces package generation script to include all interface IDs
- Remove duplicate interface ID generation from issuance package:
  * Delete InterfaceIdExtractor.sol
  * Delete generateInterfaceIds.py script
  * Delete local interfaceIds.ts helper
  * Remove generate:interfaces script from package.json
- Update issuance package to import interface IDs from @graphprotocol/interfaces
- Simplify interface compliance tests (remove redundant consistency checks)

All lint checks now pass (0 warnings) and all tests pass (161/161).
Interface IDs are now centrally managed in the interfaces package for consistency.

Author: RembrandtK

packages/contracts/contracts/tests/MockIssuanceAllocator.sol

@@ -3,8 +3,7 @@
 pragma solidity 0.7.6;
 pragma abicoder v2;
 
-// TODO: Re-enable and fix issues when publishing a new version
-// solhint-disable gas-increment-by-one, gas-indexed-events, gas-small-strings, use-natspec
+// solhint-disable gas-increment-by-one, gas-indexed-events, gas-small-strings, use-natspec, named-parameters-mapping
 
 import { ERC165 } from "@openzeppelin/contracts/introspection/ERC165.sol";
 import {

packages/interfaces/contracts/contracts/rewards/IRewardsIssuer.sol

@@ -2,9 +2,14 @@
 
 pragma solidity ^0.7.6 || 0.8.27;
 
+/**
+ * @title Rewards Issuer Interface
+ * @author Edge & Node
+ * @notice Interface for contracts that issue rewards based on allocation data
+ */
 interface IRewardsIssuer {
     /**
-     * @dev Get allocation data to calculate rewards issuance
+     * @notice Get allocation data to calculate rewards issuance
      *
      * @param allocationId The allocation Id
      * @return isActive Whether the allocation is active or not

packages/interfaces/contracts/utils/InterfaceIdExtractor.sol

@@ -3,6 +3,8 @@ pragma solidity 0.7.6;
 
 import { IRewardsManager } from "../contracts/rewards/IRewardsManager.sol";
 import { IIssuanceTarget } from "../issuance/allocate/IIssuanceTarget.sol";
+import { IIssuanceAllocator } from "../issuance/allocate/IIssuanceAllocator.sol";
+import { IRewardsEligibilityOracle } from "../issuance/eligibility/IRewardsEligibilityOracle.sol";
 import { IERC165 } from "@openzeppelin/contracts/introspection/IERC165.sol";
 
 /**
@@ -30,6 +32,22 @@ contract InterfaceIdExtractor {
         return type(IIssuanceTarget).interfaceId;
     }
 
+    /**
+     * @notice Returns the ERC-165 interface ID for IIssuanceAllocator
+     * @return The interface ID as calculated by Solidity
+     */
+    function getIIssuanceAllocatorId() external pure returns (bytes4) {
+        return type(IIssuanceAllocator).interfaceId;
+    }
+
+    /**
+     * @notice Returns the ERC-165 interface ID for IRewardsEligibilityOracle
+     * @return The interface ID as calculated by Solidity
+     */
+    function getIRewardsEligibilityOracleId() external pure returns (bytes4) {
+        return type(IRewardsEligibilityOracle).interfaceId;
+    }
+
     /**
      * @notice Returns the ERC-165 interface ID for IERC165
      * @return The interface ID as calculated by Solidity

packages/interfaces/scripts/generateInterfaceIds.py

@@ -31,6 +31,8 @@ def run_hardhat_task():
   const results = {
     IRewardsManager: await extractor.getIRewardsManagerId(),
     IIssuanceTarget: await extractor.getIIssuanceTargetId(),
+    IIssuanceAllocator: await extractor.getIIssuanceAllocatorId(),
+    IRewardsEligibilityOracle: await extractor.getIRewardsEligibilityOracleId(),
     IERC165: await extractor.getIERC165Id(),
   }
 

packages/issuance/contracts/test/InterfaceIdExtractor.sol

@@ -45,10 +45,9 @@
   "scripts": {
     "build": "pnpm build:dep && pnpm build:self",
     "build:dep": "pnpm --filter '@graphprotocol/issuance-test^...' run build:self",
-    "build:self": "tsc --build && pnpm generate:interfaces",
+    "build:self": "tsc --build",
     "build:coverage": "pnpm build:dep:coverage && pnpm build:self",
     "build:dep:coverage": "pnpm --filter '@graphprotocol/issuance-test^...' run build:coverage",
-    "generate:interfaces": "python3 scripts/generateInterfaceIds.py --silent",
     "clean": "rm -rf .eslintcache artifacts/",
     "test": "pnpm build && pnpm test:self",
     "test:self": "cd .. && hardhat test test/tests/*.test.ts test/tests/**/*.test.ts",

packages/issuance/test/package.json

@@ -2,15 +2,16 @@ import { expect } from 'chai'
 const { ethers } = require('hardhat')
 
 const { shouldSupportERC165Interface } = require('../../utils/testPatterns')
+// Import generated interface IDs from the interfaces package
+import { IIssuanceAllocator, IIssuanceTarget, IRewardsEligibilityOracle } from '@graphprotocol/interfaces'
+
 import {
   deployDirectAllocation,
   deployIssuanceAllocator,
   deployRewardsEligibilityOracle,
   deployTestGraphToken,
   getTestAccounts,
 } from '../helpers/fixtures'
-// Import generated interface IDs
-import { IIssuanceAllocator, IIssuanceTarget, IRewardsEligibilityOracle } from '../helpers/interfaceIds'
 
 /**
  * Consolidated ERC-165 Interface Compliance Tests
@@ -62,17 +63,7 @@ describe('ERC-165 Interface Compliance', () => {
     ),
   )
 
-  describe('Interface ID Consistency', () => {
-    it('should have consistent interface IDs with Solidity calculations', async () => {
-      const InterfaceIdExtractorFactory = await ethers.getContractFactory('InterfaceIdExtractor')
-      const extractor = await InterfaceIdExtractorFactory.deploy()
-
-      // Verify each interface ID matches what Solidity calculates
-      expect(await extractor.getIIssuanceAllocatorId()).to.equal(IIssuanceAllocator)
-      expect(await extractor.getIRewardsEligibilityOracleId()).to.equal(IRewardsEligibilityOracle)
-      expect(await extractor.getIIssuanceTargetId()).to.equal(IIssuanceTarget)
-    })
-
+  describe('Interface ID Validation', () => {
     it('should have valid interface IDs (not zero)', () => {
       expect(IIssuanceAllocator).to.not.equal('0x00000000')
       expect(IRewardsEligibilityOracle).to.not.equal('0x00000000')