fix: remove unused errors, use LegacyAllocationAlreadyMigrated to prevent migrating a legacy allocation twice (OZ N-02) #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove unused errors, use LegacyAllocationAlreadyMigrated to prevent migrating a legacy allocation twice (OZ N-02)
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Use LegacyAllocationAlreadyMigrated to prevent migrating a legacy allocation twice.
MoonBoi9001
force-pushed
the
fix_oz_n-02
branch
from
f44e046 to
b6d99f1
Compare
tmigone
requested changes
Sep 19, 2024
packages/subgraph-service/contracts/libraries/LegacyAllocation.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomás Migone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Title:
N-02 Unused Errors
Details:
Unused errors can negatively affect code intent and readability.
The AllocationManagerZeroTokensAllocation, DataServiceFeatureNotImplemented, and LegacyAllocationAlreadyMigrated errors are unused.
Consider deleting the AllocationManagerZeroTokensAllocation error since creating allocations with no tokens is allowed for altruistic allocations. In addition, consider deleting the DataServiceFeatureNotImplemented error and using LegacyAllocationAlreadyMigrated to prevent migrating a legacy allocation twice.
Key changes