Skip to content

Conversation

MoonBoi9001
Copy link
Member

Motivation:

Title:

N-14 Event Emission Suggestions

Details:

Throughout the codebase, multiple instances of events that could emit additional information were identified:

The AuthorizedCollector event could emit the amount for which the collector was authorized.
The TokensRescued event could emit the token that was rescued.
Consider updating these events to enhance off-chain tracking and ensure comprehensive event logging.

Key changes

  • The AuthorizedCollector event now emits the amount for which the collector was authorized.
  • The AuthorizedCollector event now emits the total amount that the collector is authorized.
  • The TokensRescued event now emits the token contract of the rescued token.

Copy link

openzeppelin-code bot commented Sep 30, 2024

fix: emit new events in AuthorizedCollector and TokensRescued. (OZ N-14)

Generated at commit: d459928cd7d05c3b1cf6aaa04905ddc76c8d6180

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
5
0
15
40
62
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@MoonBoi9001 MoonBoi9001 changed the title fix: Emit new events in AuthorizedCollector and TokensRescued. (OZ N-14) fix: emit new events in AuthorizedCollector and TokensRescued. (OZ N-14) Sep 30, 2024
commit to now emit both the amount for which the collector was authorized and also the total amount for which they are now authorized
@MoonBoi9001 MoonBoi9001 requested a review from tmigone October 2, 2024 18:18
@MoonBoi9001 MoonBoi9001 marked this pull request as ready for review October 2, 2024 18:18
Copy link
Member

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion

@MoonBoi9001 MoonBoi9001 requested a review from tmigone October 2, 2024 18:24
Copy link
Member

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@MoonBoi9001 MoonBoi9001 merged commit 8be58f9 into horizon Oct 2, 2024
7 checks passed
@MoonBoi9001 MoonBoi9001 deleted the fix_oz_n-14 branch October 2, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants