chore: reduce contract sizes to fit 24kb HorizonStaking and SubgraphService #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: reduce contract sizes to fit 24kb HorizonStaking and SubgraphService
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
tmigone
reviewed
Feb 6, 2025
| mapping(address allocationId => Allocation.State allocation) internal allocations; | ||
|
|
||
| /// @notice Legacy allocation details | ||
| mapping(address allocationId => LegacyAllocation.State allocation) public legacyAllocations; |
There was a problem hiding this comment.
Can we make this internal as well for consistency? (there is a getter)
tmigone
reviewed
Feb 6, 2025
|
|
||
| /// @notice Maximum amount of time, in seconds, allowed between presenting POIs to qualify for indexing rewards | ||
| uint256 public maxPOIStaleness; | ||
| uint256 internal maxPOIStaleness; |
There was a problem hiding this comment.
this could be made public if we make legacyAllocations internal? Also i dont think this value is accesible otherwise no?
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.