Horizon: pending changes after audit #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horizon: pending changes after audit
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
tmigone
force-pushed
the
horizon-oz2/pending-fixes
branch
from
84e6c15 to
e68d12d
Compare
tmigone
force-pushed
the
horizon-oz2/pending-fixes
branch
from
e8a47dd to
f2c3b7e
Compare
tmigone
force-pushed
the
horizon-oz2/pending-fixes
branch
from
f2c3b7e to
82e68ab
Compare
tmigone
changed the base branch from
horizon
to
horizon-oz2/h02-delegation-slashing
tmigone
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## horizon-oz2/h02-delegation-slashing #1131 +/- ##
======================================================================
Coverage ? 92.56%
======================================================================
Files ? 47
Lines ? 2435
Branches ? 440
======================================================================
Hits ? 2254
Misses ? 181
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmigone
force-pushed
the
horizon-oz2/h02-delegation-slashing
branch
2 times, most recently
from
bd9bf6d to
cd9197a
Compare
tmigone
force-pushed
the
horizon-oz2/pending-fixes
branch
from
82e68ab to
46013e9
Compare
tmigone
force-pushed
the
horizon-oz2/h02-delegation-slashing
branch
3 times, most recently
from
88312ff to
42ef624
Compare
tmigone
force-pushed
the
horizon-oz2/pending-fixes
branch
from
46013e9 to
290b8f9
Compare
Maikol
approved these changes
May 8, 2025
| require(allocation.isOpen(), AllocationManagerAllocationClosed(_allocationId)); | ||
|
|
||
| uint256 currentEpoch = _graphEpochManager().currentEpoch(); | ||
| // uint256 currentEpoch = _graphEpochManager().currentEpoch(); |
pcarranzav
reviewed
May 8, 2025
| uint256 curationCut = _curation().isCurated(subgraphDeploymentId) ? curationFeesCut : 0; | ||
| tokensCollected = _graphTallyCollector().collect( | ||
| IGraphPayments.PaymentTypes.QueryFee, | ||
| abi.encode(signedRav, curationCut), |
There was a problem hiding this comment.
Should the payment destination be encoded here too?
tmigone
force-pushed
the
horizon-oz2/pending-fixes
branch
2 times, most recently
from
be57dab to
83f40a8
Compare
tmigone
force-pushed
the
horizon-oz2/h02-delegation-slashing
branch
from
42ef624 to
9ce4d11
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
horizon-oz2/pending-fixes
branch
from
83f40a8 to
c0e83cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.